-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] KFP standalone test infra for upgradability #1971
Conversation
Verified locally, the process of deploy -> upgrade works. I need to add some integration tests to verify resources. |
/retest |
1 similar comment
/retest |
/assign @IronPan Not fully finished on |
Note that upgrade tests are passing, even though they don't show here: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/1971/kubeflow-pipeline-upgrade-test/1192674908237205504 I will update https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubeflow/kubeflow-presubmits.yaml#L337 to show upgrade tests once this PR is merged. |
Mostly LGTM. Thanks Yuan. Could you check why job.trigger is inconsistent |
/retest |
@IronPan thanks, I will verify that |
@IronPan
I think it doesn't affect behavior, might be caused by some inconsistency of writing to and reading from db model. UPDATE: I found the culprit: https://github.com/Bobgy/pipelines/blob/bec3c94a4505de4ff9129a8e598ef9aa2d6dff17/backend/src/apiserver/storage/job_store.go#L358 I will fix it in this PR. |
/retest |
/test kubeflow-pipeline-upgrade-test |
/test kubeflow-pipeline-upgrade-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
* Implement upgrade test * mark upgrade-tests.sh as executable * Fix comments * Base upgrade_test_setup.yaml * e2e integration of upgrade test * Fix entrypoint argument * Fix e2e workflow yaml * Fix run_test.sh argument processing * Fix no closing backtick * Restrucutre upgrade_test.go to focus the test on upgrade verification * clean up code * Clean up after upgrade test when it is run in integration tests. * Include pipeline tests in upgrade test * Reorder tests * Add upgrade test coverage for run api resources * Add job api resource coverage in upgrade test & refactored upgrade test * Fix add missing step in upgrade test * Fix BUILD.bazel * Fix upgrade_test.go * Try to fix upgrade test failure * Fix hard coded namespace * Sync upgrade-tests.sh with new changes in presubmit-tests-with-pipeline-deployment.sh * Update upgrade test * Remove redundant code * Fix integration test exit code * Fix trigger interval second mismatch
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Fixes #1638
/area testing
This change is