Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Components - Only yaml component files can be used as source #1966

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 27, 2019

Previously, if the file was a .zip archive, some functions (e.g. exception printing) would fail as the source is not a text file.


This change is Reviewable

Previously, if the file was a .zip archive, some functions like exception printing would fail as it's not a text file.
@Ark-kun Ark-kun force-pushed the SDK---Components---Only-yaml-component-files-can-be-used-as-source branch from 475ae4a to 2656c8a Compare August 27, 2019 20:17
@ajchili
Copy link
Member

ajchili commented Aug 27, 2019

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4cbfdd8 into kubeflow:master Aug 27, 2019
ajchili pushed a commit to ajchili/pipelines that referenced this pull request Aug 28, 2019
…ubeflow#1966)

Previously, if the file was a .zip archive, some functions like exception printing would fail as it's not a text file.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Update kserve sdk examples

Signed-off-by: Mark Winter <mark.winter@navercorp.com>

* Better var names

Signed-off-by: Mark Winter <mark.winter@navercorp.com>

* Update READMEs

Signed-off-by: Mark Winter <mark.winter@navercorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants