Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Verifying that the serializer returns string #1965

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 27, 2019

This change was prompted by the failure when b64encode was returning bytes instead of str.


This change is Reviewable

This change was prompted by the failure when b64encode was returning bytes instead of str.
Copy link
Contributor

@kevinbache kevinbache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3a30b2b into kubeflow:master Aug 27, 2019
ajchili pushed a commit to ajchili/pipelines that referenced this pull request Aug 28, 2019
This change was prompted by the failure when b64encode was returning bytes instead of str.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants