Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test infra - Fixed the batch Prow tests #1958

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 27, 2019

Fixes #1957


This change is Reviewable

@Ark-kun Ark-kun force-pushed the Test-infra---Fixed-the-batch-Prow-tests branch 2 times, most recently from c4098fa to 2a97060 Compare August 27, 2019 00:15
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 27, 2019

@Bobgy @IronPan can you please take a look?

@Ark-kun Ark-kun force-pushed the Test-infra---Fixed-the-batch-Prow-tests branch from 2a97060 to c4098fa Compare August 27, 2019 18:28
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 27, 2019

/retest

Copy link
Contributor

@dushyanthsc dushyanthsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun merged commit 856949e into kubeflow:master Aug 27, 2019
@Ark-kun Ark-kun deleted the Test-infra---Fixed-the-batch-Prow-tests branch August 27, 2019 21:16
ajchili pushed a commit to ajchili/pipelines that referenced this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tide cannot merge the batch due to error in script
5 participants