-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1953: added missed target_image parameter to build_docker_image method #1955
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Hi @pahask8. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I fixed it. |
@googlebot I fixed it |
@googlebot I fixed it. |
Fixes #1953 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @pahask8 . Your commit-e-mail seems to have a typo. Can you please try to fix it? |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/lgtm |
This is not required since the containerBuilder will automatically use the target_image from the constructor function when it builds the image. |
@gaoning777 this is required if I use it like that:
|
h5py 2.9 is not compatible with the tensorflow version required by alibiexplainer. Should just use the version pulled in by alibiexplainer kserve/kserve#1951 (comment) Signed-off-by: Mark Edward Winter <wintermarkedward@gmail.com>
Fixes #1955
This change is