Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1953: added missed target_image parameter to build_docker_image method #1955

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Conversation

pahask8
Copy link
Contributor

@pahask8 pahask8 commented Aug 26, 2019

Fixes #1955

This change is Reviewable

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @pahask8. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pahask8
Copy link
Contributor Author

pahask8 commented Aug 26, 2019

@googlebot I fixed it.

@pahask8
Copy link
Contributor Author

pahask8 commented Aug 26, 2019

@googlebot I fixed it

@pahask8
Copy link
Contributor Author

pahask8 commented Aug 26, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot I fixed it.

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 26, 2019

Fixes #1953
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 26, 2019

Hi @pahask8 . Your commit-e-mail seems to have a typo. Can you please try to fix it?

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 26, 2019
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@pahask8
Copy link
Contributor Author

pahask8 commented Aug 26, 2019

Hi @pahask8 . Your commit-e-mail seems to have a typo. Can you please try to fix it?

Hi @Ark-kun, done, please check.
Thank you

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit da2ecf7 into kubeflow:master Aug 26, 2019
@gaoning777
Copy link
Contributor

This is not required since the containerBuilder will automatically use the target_image from the constructor function when it builds the image.

@pahask8 pahask8 deleted the 1953 branch August 28, 2019 23:29
@pahask8
Copy link
Contributor Author

pahask8 commented Aug 28, 2019

@gaoning777 this is required if I use it like that:

import os
from kfp import compiler

build = compiler.build_docker_image(
    staging_gcs_path="gs://kfp-build-stage",
    target_image="gcr.io/staging/kfp-build",
    dockerfile_path="/Users/user/kubeflow_pipelines/docker_build/src/Dockerfile",
    timeout=600,
    namespace="kubeflow"
)

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
h5py 2.9 is not compatible with the tensorflow version required by alibiexplainer. Should just use the version pulled in by alibiexplainer

kserve/kserve#1951 (comment)
Signed-off-by: Mark Edward Winter <wintermarkedward@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants