Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure db host and port from from config file #1940

Merged
merged 4 commits into from
Sep 18, 2019
Merged

configure db host and port from from config file #1940

merged 4 commits into from
Sep 18, 2019

Conversation

xaniasd
Copy link
Contributor

@xaniasd xaniasd commented Aug 23, 2019 •
edited by jlewi
Loading

allow configuring all db connection parameters from config file. Set default values to avoid regression

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @xaniasd. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xaniasd
Copy link
Contributor Author

xaniasd commented Aug 23, 2019

/assign @IronPan

@xaniasd
Copy link
Contributor Author

xaniasd commented Sep 6, 2019

@IronPan can this PR be tested? any changes needed?

@IronPan
Copy link
Member

IronPan commented Sep 18, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member

IronPan commented Sep 18, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit 726551b into kubeflow:master Sep 18, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Throw error if storage initializer can not locate PVC source uri (kub…
6d3d42b 
…eflow#1940)

* Throw error if storage initializer can not locate PVC source uri

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add go lint

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajchili ajchili ajchili left review comments

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xaniasd @k8s-ci-robot @IronPan @ajchili