Move postsubmit tests to lite deployment #1939
Conversation
| @@ -114,14 +114,16 @@ elif [[ ${CLOUDBUILD_FINISHED} == TIMEOUT ]];then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # Deploy Kubeflow | |||
| source "${DIR}/deploy-kubeflow.sh" | |||
| COMMIT_SHA=$PULL_BASE_SHA source "${DIR}/deploy-cluster.sh" | |||
There was a problem hiding this comment.
the old code seems just uses pull_pull_sha.
pipelines/test/deploy-kubeflow.sh
Line 20 in 2e7f2d4
just to double check, is this pull base sha the right SHA?
There was a problem hiding this comment.
I think it might be a problem of previous code (this also works if PULL_PULL_SHA is empty).
https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables
when running postsubmit test, there's only PULL_BASE_SHA, there's no PULL_PULL_SHA
There was a problem hiding this comment.
That explains the empty sha in the GKE cluster I saw before. Great catch!
|
/hold |
|
/hold cancel |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @IronPan
This change is