-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample test improvement - using python fire to launch sample test #1897
Merged
Merged
Changes from 1 commit
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
e0c7132
Remove redundant import.
numerology 70972db
Simplify sample_test.yaml by using withItem syntax.
deb6cc0
Merge branch 'master' of https://github.com/kubeflow/pipelines
da9a42a
Simplify sample_test.yaml by using withItem syntax.
a203039
Merge branch 'master' of https://github.com/numerology/pipelines
81ccbf4
Change dict to str in withItems.
d94a945
Merge branch 'master' of https://github.com/kubeflow/pipelines
ee38eb1
Merge branch 'master' of https://github.com/kubeflow/pipelines
9b3ad8e
Merge branch 'master' of https://github.com/kubeflow/pipelines
4ba8f85
Merge branch 'master' of https://github.com/kubeflow/pipelines
2b39278
Merge branch 'master' of https://github.com/kubeflow/pipelines
3061791
Merge branch 'master' of https://github.com/kubeflow/pipelines
1cc64ec
Merge remote-tracking branch 'origin/master'
a42ac40
Merge branch 'master' of https://github.com/kubeflow/pipelines
2398017
Merge remote-tracking branch 'origin/master'
a0bd790
Merge branch 'master' of https://github.com/kubeflow/pipelines
433180c
Merge branch 'master' of https://github.com/kubeflow/pipelines
fcabe77
Merge branch 'master' of https://github.com/kubeflow/pipelines
dfc0b16
Add back coveralls.
fb734de
Squashed commit of the following:
2b6907e
WIP: rewrite sample test infra
55a8667
WIP: rewrite sample test infra
e063bc2
WIP: rewrite sample test infra
17348a8
Fixing
b77703b
WIP: add injection function in python launcher.
797b618
Refactor the logic of run_test.sh into sample_test_launcher.py
dcdefd3
Fix exit_code
aa12ff1
Fix imports and add todo
f85e10a
Squashed commit of the following:
34d25d4
Merge branch 'master' of https://github.com/kubeflow/pipelines into t…
de74804
Clean up.
b685c62
Fix launcher flag.
d1994d6
switch to sys.execxutable.
57763d0
Fix bugs
d3db0bc
Add copy blob util function
da3a5dd
Fix default image prefix.
950035f
Fix dependencies.
905610b
Fix gs op
1dab733
Lint
8c814ba
Fix papermill exec
ff26024
Init for componentTest
bc0d319
Debugging.
5dcc495
Try to fix the issue.
fffee19
Fix exit code
748e9d9
Another fix.
5e7a8c5
Squashed commit of the following:
c902070
Fix working dir
8ef3fa1
Fix exit code format
3a33af2
Merge branch 'master' of https://github.com/kubeflow/pipelines into t…
68a4089
Remove kfp notebook sample using tfx:oss components.
3de8843
Refactor to reduce potential dup code.
ad90563
Clear unused const.
fc6301a
Fix redundant check
23349b1
Add image injection for component test.
ad01f7d
Fix unused import
73b1409
Merge branch 'master' of https://github.com/kubeflow/pipelines into t…
f5a857d
Squash and merge from master
bed1135
Squashed commit of the following:
14dfd4e
# Conflicts:
a08fb85
Merge branch 'master' of https://github.com/kubeflow/pipelines into t…
e9b0cd8
Fix version for papermill
04546c5
Merge remote-tracking branch 'origin/test-improvement' into test-impr…
35ae6f5
Squashed commit of the following:
6fc6252
Merge branch 'master' of https://github.com/kubeflow/pipelines into t…
c5640bf
Fix google-cloud-storage and google fire version info.
d6a29b9
Delete run_test.sh
ad177e5
Merge from kfp master
0104c43
Squashed commit of the following:
364af5c
Merge branch 'master' of https://github.com/kubeflow/pipelines into t…
58937af
Fix check_notebook_results args.
8f21a36
Fix.
85f5391
Merge branch 'master' of https://github.com/kubeflow/pipelines into t…
e8694ab
Fix work dir path
9aed040
Fix global const naming convention
b8129b4
Remove redundant check.
7e627aa
Extract project name from result gcs dir.
0b3c323
Add error catching
2c07792
Name change.
911ceb3
Improve error catching.
55533a2
Improve error catching.
ee66780
naming correction.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, except's can be combined as such:
try:
except A:
except B:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Done.