Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/Minikube - Downgraded Docker to 18.06.1 #189

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Tests/Minikube - Downgraded Docker to 18.06.1 #189

merged 1 commit into from
Nov 12, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 10, 2018 •
edited by jlewi
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 10, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 288

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.592%
Totals Coverage Status
Change from base Build 176: 0.0%
Covered Lines: 1535
Relevant Lines: 2179
💛 - Coveralls

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

I've verified that this solution works properly.
Kubernetes still does not support Docker 18.09. kubernetes/minikube#3323 (comment)

@Ark-kun Ark-kun changed the title [WIP]Tests/Minikube - Downgraded Docker to 18.06.1 Tests/Minikube - Downgraded Docker to 18.06.1 Nov 10, 2018
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 12, 2018

@IronPan Can you please check this?

@IronPan
Copy link
Member

IronPan commented Nov 12, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f077201 into master Nov 12, 2018
@Ark-kun Ark-kun deleted the avolkov/Tests/Minikube---Downgrading-Docker-to-18.06.1 branch January 15, 2019 22:10
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi @k8s-ci-robot
Script to garbage collect leaked resources (kubeflow#189)
9e5956e 
* Create a script to cleanup leaked resources in kubeflow-ci.

* Add a README.md

* Fix lint.

* Fix lint.

* Update regex to match chainer tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@IronPan IronPan

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @coveralls @IronPan @k8s-ci-robot