Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marked scripts as executable #188

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Marked scripts as executable #188

merged 1 commit into from
Nov 10, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 10, 2018 •
edited by jlewi
Loading

chmod +x scripts

This change is Reviewable

@Ark-kun Ark-kun requested a review from IronPan November 10, 2018 00:28
@IronPan
Copy link
Member

IronPan commented Nov 10, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Nov 10, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 287

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.592%
Totals Coverage Status
Change from base Build 167: 0.0%
Covered Lines: 1535
Relevant Lines: 2179
💛 - Coveralls

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test presubmit-unit-test

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test presubmit-unit-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test presubmit-unit-test

@k8s-ci-robot k8s-ci-robot merged commit f0c189f into master Nov 10, 2018
IronPan added a commit that referenced this pull request Nov 11, 2018
@IronPan
Revert "Marked scripts as executable (#188)"
cb94d60 
This reverts commit f0c189f.
@Ark-kun Ark-kun deleted the avolkov/chmod-+x-scripts branch January 15, 2019 22:10
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@lluunn @k8s-ci-robot
Add doc on how to get logs for failed serving test (kubeflow#188)
e5eb5e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@IronPan IronPan

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @IronPan @k8s-ci-robot @coveralls