Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visualization-server service to lightweight deployment #1844

Merged
merged 13 commits into from
Aug 22, 2019
Merged

Add visualization-server service to lightweight deployment #1844

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
17dafa5
Add visualization-server service to lightweight deployment
ajchili Aug 14, 2019
778816f
Addressed PR suggestions
ajchili Aug 15, 2019
00ed3da
Added field to determine if visualization service is active and fixed…
ajchili Aug 15, 2019
a3e5999
Additional small fixes
ajchili Aug 15, 2019
d65f4de
Fixed visualization_server_test.go to reflect new changes
ajchili Aug 15, 2019
7dc6cab
Changed implementation to be fail fast
ajchili Aug 15, 2019
97f778f
Changed host name to be constant provided by environment
ajchili Aug 15, 2019
e16380f
Added retry and extracted isVisualizationServiceAlive logic to function
ajchili Aug 16, 2019
520798e
Fixed deployment.yaml file
ajchili Aug 16, 2019
ffffab7
Fixed serviceURL configuration issuse
ajchili Aug 21, 2019
ec55308
Added log message to indicate when visualization service is unreachable
ajchili Aug 21, 2019
508b145
Addressed PR comments
ajchili Aug 21, 2019
659ca82
Removed _HTTP
ajchili Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added log message to indicate when visualization service is unreachable
  • Loading branch information
@ajchili
ajchili committed Aug 21, 2019
commit ec55308e36628b10c4116857971b7a6a69790473
2 changes: 2 additions & 0 deletions backend/src/apiserver/server/visualization_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"encoding/json"
"fmt"
"github.com/cenkalti/backoff"
"github.com/golang/glog"
"github.com/kubeflow/pipelines/backend/api/go_client"
"github.com/kubeflow/pipelines/backend/src/apiserver/resource"
"github.com/kubeflow/pipelines/backend/src/common/util"
Expand Down Expand Up @@ -86,6 +87,7 @@ func isVisualizationServiceAlive(serviceURL string, initConnectionTimeout time.D
var operation = func() error {
_, err := http.Get(serviceURL)
if err != nil {
glog.Error("Unable to verify visualization service is alive!", err)
return err
}
return nil
Expand Down