openvino predict component and pipeline example #180

dtrawins · 2018-11-09T20:57:12Z

This change is

googlebot · 2018-11-09T20:57:16Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

k8s-ci-robot · 2018-11-09T20:57:26Z

Hi @dtrawins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2018-11-09T20:57:26Z

Hi @dtrawins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coveralls · 2018-11-09T21:01:41Z

Pull Request Test Coverage Report for Build 278

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.592%

Totals
Change from base Build 151:	0.0%
Covered Lines:	1535
Relevant Lines:	2179

💛 - Coveralls

coveralls · 2018-11-09T21:01:41Z

Pull Request Test Coverage Report for Build 153

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.592%

Totals
Change from base Build 151:	0.0%
Covered Lines:	1535
Relevant Lines:	2179

💛 - Coveralls

dtrawins · 2018-11-09T23:27:40Z

I signed it!

vicaire · 2018-11-10T02:47:39Z

Hi @dtrawins,

The comments from one of the robots above provide details instructions on how to pass the CLA check.

See the comment starting with:

"Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA)."

Thank you!

dtrawins · 2018-11-13T21:56:08Z

I should be now in the required CLA group. Could you revalidate it now?

googlebot · 2018-11-13T21:56:10Z

CLAs look good, thanks!

vicaire

This looks good to me as well. Could you please just move the component to /contrib/components/openvino?

Thanks!

dtrawins · 2018-11-16T12:20:52Z

component path changed to contrib/components/openvino as requested

vicaire · 2018-11-16T20:57:05Z

/retest

vicaire

Hi, there seems to be two more files in the samples directory. Could we move them to the /contrib directory as well?

vicaire · 2018-11-16T20:59:11Z

samples/openvino/predict/numpy_predict.py

@@ -0,0 +1,28 @@
+import kfp.dsl as dsl
+


This file is still in the /samples directory. Could we move it to the /contrib directory?

samples are now also moved to contrib

vicaire · 2018-11-16T20:59:18Z

samples/openvino/predict/README.md

@@ -0,0 +1,27 @@
+# OpenVINO predict pipeline
+
+This is an example of simple one step pipeline implementation including OpenVINO predict component.


This file is still in the /samples directory. Could we move it to the /contrib directory?

samples are now also moved to contrib

vicaire · 2018-11-16T23:52:27Z

/lgtm
/approve

k8s-ci-robot · 2018-11-16T23:52:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vicaire]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2018-11-16T23:52:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vicaire]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vicaire · 2018-11-16T23:54:41Z

Bypassing the e2e tests since they are not affected by these changes.

k8s-ci-robot · 2018-11-16T23:58:10Z

@dtrawins: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
presubmit-unit-test	`27468b1`	link	`/test presubmit-unit-test`
build-image	`27468b1`	link	`/test build-image`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

…beflow#180) * Modified run_e2etest script * Add more logs * Use util to get changed files * Add logs * Change git diff command * Fix broken tests * Fix broken tests * Testing with a fake prow_config * Remove verbose logs * Fix script error * Revert prow_config * Update README.md * Change job_types and include_dirs to arrays * Remove obsolete test * Fix lint error * Fix comments and argument parsing

* apply pylint testing for kfserving python code * fix some pylint errors

openvino predict component and pipeline example

837c917

k8s-ci-robot requested review from gaoning777 and qimingj November 9, 2018 20:57

k8s-ci-robot requested a review from Ark-kun November 9, 2018 20:57

k8s-ci-robot added the size/L label Nov 9, 2018

k8s-ci-robot added needs-ok-to-test labels Nov 9, 2018

vicaire suggested changes Nov 16, 2018

View reviewed changes

component moved to contrib folder

e990e78

vicaire suggested changes Nov 16, 2018

View reviewed changes

moved samples to contrib

27468b1

k8s-ci-robot assigned vicaire Nov 16, 2018

k8s-ci-robot added the lgtm label Nov 16, 2018

k8s-ci-robot added the approved label Nov 16, 2018

vicaire merged commit 14a0260 into kubeflow:master Nov 16, 2018

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023

Apply pylint testing for kfserving python code (kubeflow#180)

117bd20

* apply pylint testing for kfserving python code * fix some pylint errors

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openvino predict component and pipeline example #180

openvino predict component and pipeline example #180

dtrawins commented Nov 9, 2018 •

edited by jlewi

Loading

googlebot commented Nov 9, 2018

k8s-ci-robot commented Nov 9, 2018

k8s-ci-robot commented Nov 9, 2018

coveralls commented Nov 9, 2018

coveralls commented Nov 9, 2018

dtrawins commented Nov 9, 2018

vicaire commented Nov 10, 2018

dtrawins commented Nov 13, 2018

googlebot commented Nov 13, 2018

vicaire left a comment

dtrawins commented Nov 16, 2018

vicaire commented Nov 16, 2018

vicaire left a comment

vicaire Nov 16, 2018

dtrawins Nov 16, 2018

vicaire Nov 16, 2018

dtrawins Nov 16, 2018

vicaire commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

vicaire commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

		@@ -0,0 +1,27 @@
		# OpenVINO predict pipeline

		This is an example of simple one step pipeline implementation including OpenVINO predict component.

openvino predict component and pipeline example #180

openvino predict component and pipeline example #180

Conversation

dtrawins commented Nov 9, 2018 • edited by jlewi Loading

googlebot commented Nov 9, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

k8s-ci-robot commented Nov 9, 2018

k8s-ci-robot commented Nov 9, 2018

coveralls commented Nov 9, 2018

Pull Request Test Coverage Report for Build 278

💛 - Coveralls

coveralls commented Nov 9, 2018

Pull Request Test Coverage Report for Build 153

💛 - Coveralls

dtrawins commented Nov 9, 2018

vicaire commented Nov 10, 2018

dtrawins commented Nov 13, 2018

googlebot commented Nov 13, 2018

vicaire left a comment

Choose a reason for hiding this comment

dtrawins commented Nov 16, 2018

vicaire commented Nov 16, 2018

vicaire left a comment

Choose a reason for hiding this comment

vicaire Nov 16, 2018

Choose a reason for hiding this comment

dtrawins Nov 16, 2018

Choose a reason for hiding this comment

vicaire Nov 16, 2018

Choose a reason for hiding this comment

dtrawins Nov 16, 2018

Choose a reason for hiding this comment

vicaire commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

vicaire commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

dtrawins commented Nov 9, 2018 •

edited by jlewi

Loading