Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move argo installation to dockerfile from bash script. #1792

Merged
merged 28 commits into from
Aug 13, 2019
Merged

Move argo installation to dockerfile from bash script. #1792

merged 28 commits into from
Aug 13, 2019

Conversation

numerology
Copy link

@numerology numerology commented Aug 9, 2019 •
edited by jlewi
Loading

This PR is part of issue #1750 .
It moves argo installation to dockerfile to reduce duplicated logic and procedure, to improve test efficiency.

This change is Reviewable

numerology and others added 14 commits July 23, 2019 15:13
@numerology
Remove redundant import.
e0c7132
Simplify sample_test.yaml by using withItem syntax.
70972db
Merge branch 'master' of https://github.com/kubeflow/pipelines
deb6cc0
Simplify sample_test.yaml by using withItem syntax.
da9a42a
Merge branch 'master' of https://github.com/numerology/pipelines
a203039
Change dict to str in withItems.
81ccbf4
Merge branch 'master' of https://github.com/kubeflow/pipelines
d94a945
Merge branch 'master' of https://github.com/kubeflow/pipelines
ee38eb1
Merge branch 'master' of https://github.com/kubeflow/pipelines
9b3ad8e
Merge branch 'master' of https://github.com/kubeflow/pipelines
4ba8f85
Merge branch 'master' of https://github.com/kubeflow/pipelines
2b39278
Merge branch 'master' of https://github.com/kubeflow/pipelines
3061791
Move argo installation to docker file.
d374533
Remove TODO
c0f2226
@numerology
Copy link
Author

/test kubeflow-pipeline-e2e-test

1 similar comment
@numerology
Copy link
Author

/test kubeflow-pipeline-e2e-test

@numerology
Copy link
Author

/test kubeflow-pipeline-e2e-test

@numerology numerology changed the title [WIP] Move argo installation to dockerfile from bash script. Move argo installation to dockerfile from bash script. Aug 12, 2019
@numerology
Copy link
Author

Note: I added 'sh' in python subprocess call to fix OSError: [Errno 8] Exec format error in python, which seems to be a result from setting up argo from another layer in docker image.

@numerology
Copy link
Author

/test kubeflow-pipeline-sample-test

@numerology
Copy link
Author

/test kubeflow-pipeline-sample-test

@numerology
Copy link
Author

/test kubeflow-pipeline-e2e-test

1 similar comment
@numerology
Copy link
Author

/test kubeflow-pipeline-e2e-test

@numerology
Copy link
Author

/test kubeflow-pipeline-sample-test

@numerology
Copy link
Author

/test all

@numerology
Copy link
Author

/test all

@gaoning777
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology numerology merged commit 68138ec into kubeflow:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@gaoning777 gaoning777

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numerology @gaoning777 @k8s-ci-robot