Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update owner files in samples and test #1785

Merged
merged 5 commits into from
Aug 13, 2019
Merged

update owner files in samples and test #1785

merged 5 commits into from
Aug 13, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Aug 9, 2019

This change is Reviewable

@numerology
Copy link

Thanks! @gaoning777

@numerology numerology self-requested a review August 9, 2019 16:34
@numerology
Copy link

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

test/OWNERS Show resolved Hide resolved
@IronPan
Copy link
Member

IronPan commented Aug 9, 2019

/hold

Copy link

@numerology numerology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 9, 2019
@numerology
Copy link

/test kubeflow-pipeline-e2e-test

@numerology
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 10, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 12, 2019

/lgtm

@IronPan
Copy link
Member

IronPan commented Aug 13, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 13, 2019
@numerology
Copy link

/lgtm

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

1 similar comment
@numerology
Copy link

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit d8dc8bf into kubeflow:master Aug 13, 2019
@gaoning777 gaoning777 deleted the add-clean-sample-test-owners branch August 13, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants