Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images, bug fixes, clean up code #1778

Merged
merged 4 commits into from
Aug 9, 2019

Conversation

carolynwang
Copy link
Contributor

@carolynwang carolynwang commented Aug 8, 2019

@Jeffwan @mbaijal @gautamkmr @kalyc

Summary

  • Update images
  • Bug fixes in utils functions, remove print transformation job results (it was specific to kmeans)
  • Remove unused imports
  • Minor fixes in mini image classification pipeline parameters

Testing

  • Sample pipelines compile and run using default inputs

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @carolynwang. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ground_truth_train_manifest_location='s3://your-bucket-name/gt-demo-images/ground-truth-demo/train.manifest',
ground_truth_validation_manifest_location='s3://your-bucket-name/gt-demo-images/ground-truth-demo/validation.manifest',
ground_truth_output_location='s3://your-bucket-name/gt-demo-images/ground-truth-demo/output',
ground_truth_train_manifest_location='s3://your-bucket-name/mini-image-classification/ground-truth-demo/train.manifest',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like to confirm it's mini - small image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very small set of images

@Jeffwan
Copy link
Member

Jeffwan commented Aug 9, 2019

/hold

Hold the changes since @carolynwang will have a bug bash for all the components today.

@Jeffwan
Copy link
Member

Jeffwan commented Aug 9, 2019

/hold cancel
/lgtm

@Jeffwan
Copy link
Member

Jeffwan commented Aug 9, 2019

/ok-to-test

@Jeffwan
Copy link
Member

Jeffwan commented Aug 9, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 69ca3c7 into kubeflow:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants