Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/DSL/Compiler - Improved compilation of dsl.Conditional - UX support done #177

Merged
merged 4 commits into from
Nov 19, 2018
Merged

SDK/DSL/Compiler - Improved compilation of dsl.Conditional - UX support done #177

merged 4 commits into from
Nov 19, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 9, 2018 •
edited by jlewi
Loading

This change is Reviewable

qimingj
qimingj approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@qimingj qimingj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ark-kun.

@qimingj
Copy link
Contributor

qimingj commented Nov 9, 2018

/lgtm

@rileyjbauer rileyjbauer mentioned this pull request Nov 15, 2018
Merged
@rileyjbauer @k8s-ci-robot
Update frontend handling of graphs (#293)
7e56199 
* Updates the frontend to correctly parse the new format of conditional pipelines

* WIP - Assume tasks and templates don't share names

* Greatly simplifies graphing of conditional and non-conditional pipelines

* Adds/updates StaticParser tests

* Give nodes unique names
@Ark-kun Ark-kun changed the title [WIP] SDK/DSL/Compiler - Improved compilation of dsl.Conditional - Waiting for UX support SDK/DSL/Compiler - Improved compilation of dsl.Conditional - Waiting for UX support Nov 17, 2018
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 17, 2018

The UX changes are checked in.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 17, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Ark-kun: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@Ark-kun: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rileyjbauer
Copy link
Contributor

/lgtm

@Ark-kun Ark-kun changed the title SDK/DSL/Compiler - Improved compilation of dsl.Conditional - Waiting for UX support SDK/DSL/Compiler - Improved compilation of dsl.Conditional - UX support done Nov 17, 2018
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 17, 2018

/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 17, 2018

Needs approval from @rileyjbauer or @yebrahim

@rileyjbauer
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 906ad68 into master Nov 19, 2018
@Ark-kun Ark-kun deleted the avolkov/Fixed-compilation-of-dsl.Conditional-2 branch January 15, 2019 22:10
@jingzhang36 jingzhang36 mentioned this pull request Jan 21, 2020
Closed
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi @k8s-ci-robot
Document how to Use the new stackdriver agents in our test cluster. (k…
ddcc988 
…ubeflow#309)

* We upgraded the test cluster to use the new stackdriver monitoring
  to make it easier to monitor Kubeflow.

* This PR updates the readme to provide instructions on how to leverage that.

* Fix kubeflow#177
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@SachinVarghese @k8s-ci-robot
Creating Go Client Libraries for KFservice CRD (kubeflow#177)
7ec6d11 
* updating dependancies for generating static go client files

* Adding a shell script to create the static client for KFservice

* adding generated go client libraries

* Adding the update and verify codegen scripts

* Adding verify codegen to CI process and update codegen to Makefile

* Adding additional deps for client codegen

* update verify-codegen.sh

* Updating hack scripts
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@fenglixa
consolidate the value of results - address comments from ckadner (kub…
d592ebf 
…eflow#177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qimingj qimingj qimingj approved these changes

@rileyjbauer rileyjbauer Awaiting requested review from rileyjbauer

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@yebrahim yebrahim

@qimingj qimingj

@rileyjbauer rileyjbauer

Labels
approved area/sdk/dsl/compiler lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ark-kun @qimingj @k8s-ci-robot @rileyjbauer @yebrahim