Not return error if run update doesn't change DB entry #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @hongye-sun |
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Replace AWS_REGION with AWS_DEFAULT_REGION The boto3 package seems to look for AWS_DEFAULT_REGION, meanwhile kfserving uses AWS_REGION, that doesn't seem to be working (tested following https://github.com/kubeflow/kfserving/blob/master/docs/samples/storage/s3/README.md). This change doesn't replace all occurrences of AWS_REGION, but only the ones that set the environment variables. kubeflowGH-1765 * s3_secrets: support AWS_CA_BUNDLE This change adds the possibility to force boto to use a different CA bundle path when validating the TLS certificate of the S3 endpoint. Our use case is to validate a TLS certificate of an internal Openstack Swift/S3 endpoint signed by our internal CA. kubeflowGH-1766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many error from Persistence Agent log
"Permanent failure while syncing resource (kubeflow/resubmit-vptp6): CustomError (code: 1): Syncing Workflow (resubmit-vptp6): permanent failure: CustomError (code: 1): Error while reporting workflow resource (code: InvalidArgument, message: Report workflow failed.: Invalid input error: Failed to update run 82be5fa1-ce58-4819-a0a4-754fcbc258ac. Row not found. "
This is due to run not change in the database. Fix the logic in API server to not treat this as error.
This change is