Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coveralls for frontend code coverage #176

Merged
merged 6 commits into from
Nov 9, 2018
Merged

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Nov 9, 2018

Also adds the coveralls badge to root README.

We should also figure out how to add to that coverage data to cover all our tested code.


This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Nov 9, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 006433e into master Nov 9, 2018
@yebrahim yebrahim deleted the yebrahim/coveralls branch November 11, 2018 04:31
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
HumairAK added a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Update http2/grpc packages and Add CA injection to step-copy-artifacts step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants