Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Adding CLI integration tests for jobs. Adding new required parameters for jobs and runs based on recent API changes. #174

Closed
wants to merge 3 commits into from
Closed

[WIP] Adding CLI integration tests for jobs. Adding new required parameters for jobs and runs based on recent API changes. #174

wants to merge 3 commits into from

Conversation

vicaire
Copy link
Contributor

@vicaire vicaire commented Nov 9, 2018 •
edited by jlewi
Loading

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vicaire

If they are not already assigned, you can assign the PR to them by writing /assign @vicaire in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicaire vicaire changed the title Adding integration tests for jobs. Adding new required parameters for jobs and runs based on recent API changes. [WIP] Adding integration tests for jobs. Adding new required parameters for jobs and runs based on recent API changes. Nov 9, 2018
@vicaire vicaire removed the request for review from qimingj November 9, 2018 10:20
@vicaire vicaire changed the title [WIP] Adding integration tests for jobs. Adding new required parameters for jobs and runs based on recent API changes. [WIP] Adding CLI integration tests for jobs. Adding new required parameters for jobs and runs based on recent API changes. Nov 10, 2018
@coveralls
Copy link

coveralls commented Nov 10, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 194

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.592%
Totals Coverage Status
Change from base Build 185: 0.0%
Covered Lines: 1535
Relevant Lines: 2179
💛 - Coveralls

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 10, 2018

/test presubmit-unit-test

@k8s-ci-robot
Copy link
Contributor

@vicaire: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
build-image 5f7b420 link /test build-image
presubmit-e2e-test c17b06f link /test presubmit-e2e-test
presubmit-unit-test 5f7b420 link /test presubmit-unit-test
kubeflow-pipeline-sample-test 5f7b420 link /test kubeflow-pipeline-sample-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@IronPan
Copy link
Member

IronPan commented Jul 10, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@IronPan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan IronPan deleted the vicaire/cli branch July 10, 2019 18:35
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@jlewi @k8s-ci-robot
Overhaul the way we upgrade dev.kubeflow.org (kubeflow#174)
b8f1691 
* Don't delete and recreate the ksonnet app.
* Use the new upgrade script in kubeflow/kubeflow#1100

* Move creation of secrets into a separate script; there's no
  reason to recreate them just to update the app.

* Add a bunch of fixes in redeploy_app.sh to deal with various issues
  in the way ks apply works; see comments in code for links to
  the issues.

* Update the docs.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@ellistarn
Linked to working group on front page README (kubeflow#174)
6986a37
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@ckadner
Add end-to-end compiler tests (kubeflow#174)
c1b7410 
- Regenerate all "Golden" YAML files with PipelineRun
- Dynamically generate E2E test cases from "Golden" YAML files
- Add e2e_test target to Makefile
- Generate new "Golden" log files from Tekton pipeline run
- Fix PendingDeprecationWarning: dsl.ContainerOp....` will be removed in future releases
  Use `dsl.ContainerOp.container....` instead.
- Fix UserWarning: Missing type name was inferred as ...

Resolves #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vicaire @k8s-ci-robot @coveralls @Ark-kun @IronPan