Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Watson Machine Learning auth with IAM #1737

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Aug 5, 2019

Starting from Aug 1st, Watson ML requires IAM auth using the apikey for authentication. Thus, we need to update our client code and creds.ini to include apikey from now on.

/assign @animeshsingh


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @Tomcli. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this in addition to username/password?

@Tomcli
Copy link
Member Author

Tomcli commented Aug 5, 2019

username/password becomes optional now since the apikey is mandatory due to IAM auth. username/password is still being used for services such as openscale, but for train/store/deploy we can opt out. I can remove the username/password section if it confuses the users.

@Tomcli
Copy link
Member Author

Tomcli commented Aug 5, 2019

Looks like the Watson ML product team decided to deprecate the username/password way of authentication, I will remove those reference in my next commit.

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Aug 5, 2019
@Tomcli
Copy link
Member Author

Tomcli commented Aug 6, 2019

@animeshsingh I removed all the old username/password reference and should be good to go now.

Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 79b58d7 into kubeflow:master Aug 8, 2019
@Tomcli Tomcli deleted the fix-watson-auth branch February 28, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants