-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Watson Machine Learning auth with IAM #1737
Conversation
Hi @Tomcli. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this in addition to username/password?
username/password becomes optional now since the apikey is mandatory due to IAM auth. username/password is still being used for services such as openscale, but for train/store/deploy we can opt out. I can remove the username/password section if it confuses the users. |
Looks like the Watson ML product team decided to deprecate the username/password way of authentication, I will remove those reference in my next commit. |
@animeshsingh I removed all the old username/password reference and should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Starting from Aug 1st, Watson ML requires IAM auth using the
apikey
for authentication. Thus, we need to update our client code and creds.ini to includeapikey
from now on./assign @animeshsingh
This change is