Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/Components - Switched the generated inputs/outputs structure from dict to list #173

Merged
merged 1 commit into from
Nov 10, 2018
Merged

SDK/Components - Switched the generated inputs/outputs structure from dict to list #173

merged 1 commit into from
Nov 10, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 9, 2018 •
edited by jlewi
Loading

This change is Reviewable

gaoning777
gaoning777 approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@qimingj
Copy link
Contributor

qimingj commented Nov 10, 2018

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test presubmit-e2e-test

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test build-image

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test presubmit-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 09e4146 into master Nov 10, 2018
IronPan added a commit that referenced this pull request Nov 11, 2018
@IronPan
Revert "SDK/Components - Switched the generated inputs/outputs struct…
0d178c4 
…ure from dict to list (#173)"

This reverts commit 09e4146.
@Ark-kun Ark-kun deleted the avolkov/Switched-the-generated-inputs/outputs-structure-from-dict-to-list branch January 15, 2019 22:10
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@ellistarn @k8s-ci-robot
Updates the Roadmap for Q2/Q3 (kubeflow#173)
3676469 
* Updates the Roadmap for Q2/Q3

* Addressed PR comments
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@fenglixa
Change bigger to big, fix issues introduced by PR 170 (kubeflow#173)
81f578a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qimingj qimingj qimingj approved these changes

@gaoning777 gaoning777 gaoning777 approved these changes

Assignees

@gaoning777 gaoning777

@qimingj qimingj

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @qimingj @k8s-ci-robot @gaoning777