Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/DSL-compiler - Compile without temporary files #172

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 9, 2018

This also avoids writing, closing and then reading again the same temporary file which is not always supported.


This change is Reviewable

This also avoids writing, closing and then reading again the same temporary file which is not always supported.
@qimingj
Copy link
Contributor

qimingj commented Nov 10, 2018

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test build-image

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test presubmit-unit-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test build-image

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 10, 2018

/test presubmit-unit-test

@k8s-ci-robot k8s-ci-robot merged commit 43b2381 into master Nov 10, 2018
IronPan added a commit that referenced this pull request Nov 11, 2018
@Ark-kun Ark-kun deleted the avolkov/Compile-without-temporary-files branch January 15, 2019 22:10
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…ubeflow#172)

* We are seeing lots of test flakes doing to temporary problems connecting
  to the K8s master.

Related to kubeflow#169
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* update imagepullsecret and update to v0.13.0

* fix typo and update tracking issues

* fix merging conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants