Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - ContainerOp.set_display_name should return self to enable chaining #1718

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 2, 2019

This is needed so that it can be chained:

task = op(...).set_display_name('Bla')

/assign @gaoning777


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 2, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 6, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4fb329e into master Aug 6, 2019
@Ark-kun Ark-kun changed the title SDK - ContainerOp.set_display_name should return self SDK - ContainerOp.set_display_name should return self to enable chaining Aug 12, 2019
@Ark-kun Ark-kun deleted the SDK---ContainerOp.set_display_name-should-return-self branch August 13, 2019 23:43
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
They achieve exactly the same functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants