Fixes cloning of recurring runs #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies NewRun a little Creates NewRunParameters component
|
/retest |
Ark-kun
reviewed
Aug 2, 2019
| @@ -170,8 +171,8 @@ class RecurringRunDetails extends Page<{}, RecurringRunConfigState> { | |||
| const pageTitle = run ? run.name! : runId; | |||
|
|
|||
| const toolbarActions = [...this.props.toolbarProps.actions]; | |||
| toolbarActions[1].disabled = !!run.enabled; | |||
| toolbarActions[2].disabled = !run.enabled; | |||
| toolbarActions[2].disabled = !!run.enabled; | |||
There was a problem hiding this comment.
We can probably improve upon the practice of accessing toolbar items by index.
There was a problem hiding this comment.
Yes, I will work on a follow-up PR for this
There was a problem hiding this comment.
Follow-up: #1812
|
/lgtm |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1266
Simplifies NewRun a little by separating out NewRunParameters into its own component.
There were a number of issues with the way recurring runs were handled in the frontend and backend that were addressed in this PR and the others referenced in #1266.
With this PR, users can no longer swap between one-off and recurring when cloning a run. Recurring runs and single runs are ostensibly similar but there are nuances to the way they are handled in the backend that makes treating them as interchangeable problematic.
Similarly, users can no longer switch Pipelines after reaching NewRun via cloning. This extra flexibility isn't worth the complexity it adds.
This PR also adds a
clonebutton to the details page for a recurring run.Keeping track of parameters within the Pipeline object in NewRun was causing problems because in that component, Pipeline can be an API Pipeline object or something else such as a manifest from a run created from a notebook. To address this, parameters are now kept separately in their own variable in NewRun's state.
This change is