Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend - Starting the api-server container build from scratch #1699

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jul 29, 2019

This reduces the image size, reduces the attack surface and avoids security vulnerabilities.
Fixes #1545

The image size is 80% smaller and it has probably no known vulnerabilities.


This change is Reviewable

This reduces the image size, reduces the attack surface and avoids security vulnerabilities.
Fixes kubeflow#1545
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 30, 2019

/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@IronPan
Copy link
Member

IronPan commented Aug 1, 2019

/lgtm
/approve

thanks a lot for the fix!

@IronPan IronPan removed the approved label Aug 1, 2019
@Ark-kun Ark-kun changed the title [WIP] Backend - Starting the container build from scratch Backend - Starting the container build from scratch Aug 1, 2019
@Ark-kun Ark-kun changed the title Backend - Starting the container build from scratch Backend - Starting the api-server container build from scratch Aug 1, 2019
@IronPan
Copy link
Member

IronPan commented Aug 2, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image gcr.io/ml-pipeline/api-server:0.1.16 has many security issues
3 participants