Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kustomize manifests a dedicate directory #1690

Merged
merged 15 commits into from
Jul 30, 2019
Merged

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Jul 26, 2019

We will have a side by side directory for HELM registry in the future for GCP marketplace deployment.

Also bump the API version for K8s resources for consistency.

/assign @neuromage


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 29, 2019

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Jul 29, 2019

/approve

@IronPan
Copy link
Member Author

IronPan commented Jul 29, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 29, 2019

@IronPan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test 819dc4f link /test kubeflow-pipeline-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan IronPan merged commit 609c7a6 into kubeflow:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants