Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container op mount secret sample #1676

Merged

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Jul 25, 2019

Adding a basic sample to address #993.


This change is Reviewable

samples/basic/secret.py Outdated Show resolved Hide resolved
samples/basic/secret.py Outdated Show resolved Hide resolved
samples/basic/secret.py Outdated Show resolved Hide resolved
samples/basic/secret.py Outdated Show resolved Hide resolved
@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 25, 2019

/test kubeflow-pipeline-sample-test

samples/basic/secret.py Outdated Show resolved Hide resolved
@numerology numerology self-requested a review August 1, 2019 16:22
@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 3, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6668be4 into kubeflow:master Aug 3, 2019
@SinaChavoshi SinaChavoshi deleted the ContainerOp_mount_secret_sample branch August 5, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants