Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visualization API service to frontend #1675

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Add visualization API service to frontend #1675

merged 1 commit into from
Jul 25, 2019

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Jul 25, 2019 •
edited by jlewi
Loading

This change is Reviewable

@ajchili
Copy link
Member Author

ajchili commented Jul 25, 2019

/test kubeflow-pipeline-e2e-test

rileyjbauer
rileyjbauer reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a4813ff into kubeflow:master Jul 25, 2019
@ajchili ajchili deleted the ajchili/frontend-api-interaction-support branch August 8, 2019 15:58
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@xuhdev
Fix an example on KO_DOCKER_REPO in the dev guide (kubeflow#1675)
968cf3e 
It should be `docker.io/<username>` and you use this throughout the rest
of the doc. One example mistypes `docker.io/<username>/[project]`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyjbauer rileyjbauer rileyjbauer left review comments

@yebrahim yebrahim Awaiting requested review from yebrahim

Assignees

@rileyjbauer rileyjbauer

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajchili @k8s-ci-robot @rileyjbauer