-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sets min height/width of all fullscreen viewers to 80% #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* In kubeflow/kubeflow#1109 We are seeing lots of timeouts waiting for the test workflows too complete. * Bump the timeout to 1 hour.
* Add logic for pb to internal model * Add logic for pb to internal model * Note issue with scalars * Add pb conversion for scalars * Fix error log, add options for CLI * Use pointers to construct internal model * Update dims to catch non-batchable inputs * Complete pb2internal except for one edge case * Need to confirm whether there is a default shape when TensorShape is nil in SigDef * Make CLI more user friendly * Return errors instead of log fatal * Make code more readable and fail fast
…low#167) * update conditional feature with the catalog condition approach * fix lint errors * add catalog condition template * change parameter name * Init README * amend parameter reference * Add documentation and increase clarity of code * improve readability * Update catalog
Update http/grpc packages.
Fixes #160
Properly sizing the fullscreen viewer for HTML artifacts is difficult because we use iframes.
This is something of a workaround to ensure all viewers expand sufficiently in fullscreen mode until we can determine a better way to size them automatically.
This change is