Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets min height/width of all fullscreen viewers to 80% #167

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Nov 9, 2018

Fixes #160

Properly sizing the fullscreen viewer for HTML artifacts is difficult because we use iframes.

This is something of a workaround to ensure all viewers expand sufficiently in fullscreen mode until we can determine a better way to size them automatically.


This change is Reviewable

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8c2110d into master Nov 9, 2018
@rileyjbauer rileyjbauer deleted the maximize-size-of-fullscreen-viewers branch November 12, 2018 17:50
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* In kubeflow/kubeflow#1109 We are seeing lots of timeouts waiting for the
  test workflows too complete.

* Bump the timeout to 1 hour.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Add logic for pb to internal model

* Add logic for pb to internal model

* Note issue with scalars

* Add pb conversion for scalars

* Fix error log, add options for CLI

* Use pointers to construct internal model

* Update dims to catch non-batchable inputs

* Complete pb2internal except for one edge case

* Need to confirm whether there is a default shape when TensorShape is
nil in SigDef

* Make CLI more user friendly

* Return errors instead of log fatal

* Make code more readable and fail fast
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…low#167)

* update conditional feature with the catalog condition approach

* fix lint errors

* add catalog condition template

* change parameter name

* Init README

* amend parameter reference

* Add documentation and increase clarity of code

* improve readability

* Update catalog
HumairAK added a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants