Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples - Cleaned up unnecessary usage of PipelineParam #1631

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jul 16, 2019

This change is Reviewable

@gaoning777
Copy link
Contributor

/lgtm

@gaoning777
Copy link
Contributor

Since some of the samples are not tested, for example openvino, please check twice before merging.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 19, 2019

/approve

@IronPan
Copy link
Member

IronPan commented Jul 22, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 23, 2019

/test kubeflow-pipeline-e2e-test
/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit 3da6e90 into kubeflow:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants