Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate database password when init db connection #1627

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Jul 16, 2019

/assign @neuromage


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Jul 16, 2019

/assign @yaronha

@k8s-ci-robot
Copy link
Contributor

@IronPan: GitHub didn't allow me to assign the following users: yaronha.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @yaronha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaronha
Copy link
Contributor

yaronha commented Jul 16, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@yaronha: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan
Copy link
Member Author

IronPan commented Jul 16, 2019

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Jul 16, 2019

/test kubeflow-pipeline-sample-test

@IronPan
Copy link
Member Author

IronPan commented Jul 16, 2019

will fix part of #1624

@IronPan
Copy link
Member Author

IronPan commented Jul 17, 2019

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit 974ab62 into kubeflow:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants