SDK - Lightweight - Added support for "None" default values #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was impossible to pass None to components since it was being converted to the string "None".
Ark-kun
force-pushed
the
SDK---Lightweight---Added-support-for-"None"-default-values-2
branch
from
24a016b
to
68a2767
Compare
gaoning777
reviewed
Jul 18, 2019
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
SDK---Lightweight---Added-support-for-"None"-default-values-2
branch
dpoulopoulos
added a commit
to dpoulopoulos/skin-cancer-detection
that referenced
this pull request
Jul 18, 2024
Make the pipeline more dynamic by removing the static values in code. There is a special case when passing default values: The pipeline's compiler doesn't seem to handle `None` values correctly. Thus, in case of a list, we're passing `list()` instead of `None` as the default value. Despite the claims of the following PR, `None` values don't seem to work: kubeflow/pipelines#1626 Signed-off-by: Dimitris Poulopoulos <dimitris.a.poulopoulos@gmail.com>
dpoulopoulos
added a commit
to dpoulopoulos/skin-cancer-detection
that referenced
this pull request
Jul 18, 2024
Make the pipeline more dynamic by removing the static values in code. There is a special case when passing default values: The pipeline's compiler doesn't seem to handle `None` values correctly. Thus, in case of a list, we're passing `list()` instead of `None` as the default value. Despite the claims of the following PR, `None` values don't seem to work: kubeflow/pipelines#1626 Signed-off-by: Dimitris Poulopoulos <dimitris.a.poulopoulos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was impossible to pass None to components since it was being converted to the string "None".
Fixes #1485
This change is