Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog #1618

Merged
merged 2 commits into from
Jul 17, 2019
Merged

update changelog #1618

merged 2 commits into from
Jul 17, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Jul 13, 2019

This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Jul 16, 2019

It seems removed old logs. could you revert those part of the change?

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

1 similar comment
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@IronPan
Copy link
Member

IronPan commented Jul 17, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 17, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 17, 2019

/test kubeflow-pipeline-e2e-test

@gaoning777 gaoning777 merged commit d4f2b1e into kubeflow:master Jul 17, 2019
@gaoning777 gaoning777 deleted the update-change-log branch July 17, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants