Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update samples to use the latest versions of the python SDK #1607

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Update samples to use the latest versions of the python SDK #1607

merged 3 commits into from
Jul 15, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Jul 10, 2019 •
edited by jlewi
Loading

This change is Reviewable

@gaoning777 gaoning777 requested a review from Ark-kun July 10, 2019 22:51
@gaoning777 gaoning777 requested review from neuromage and IronPan and removed request for animeshsingh July 10, 2019 22:51
neuromage
neuromage reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@neuromage neuromage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

samples/ai-platform/Chicago Crime Pipeline.ipynb Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added lgtm and removed lgtm labels Jul 11, 2019
@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 15, 2019

/lgtm
We need to make sure that the package on PyPI is always up to date.

@gaoning777
Copy link
Contributor Author

/approve

@gaoning777
Copy link
Contributor Author

Pypi release is already one step in the release playbook.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1793c6b into kubeflow:master Jul 15, 2019
@gaoning777 gaoning777 deleted the update-sample-latest-kfp branch July 16, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animeshsingh animeshsingh animeshsingh left review comments

@neuromage neuromage neuromage left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@neuromage neuromage

@Ark-kun Ark-kun

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gaoning777 @googlebot @Ark-kun @k8s-ci-robot @neuromage @animeshsingh