-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Set ttlSecondsAfterFinished in argo workflow with PipelineConf #1594
Conversation
Hi @eterna2. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold |
/lgtm |
/hold cancel |
Background
Workflow resources are not removed after kf runs. Some of my runs involves hundreds of pods, which can result in a slow-down in the UI if there are not GC.
I know there is #844. So I am wondering what are the current workarounds? Currently, I am just running a cron job to remove resources > X days from creations.
So I am wondering if it is better to allow the sdk to set the
ttlSecondsAfterFinished
for the pipeline?PR
This PR adds a new method
set_ttl_seconds_after_finished
toPipelineConf
whereby the compiler will insert a new fieldttlSecondsAfterFinished
to the workflow spec ifttl_seconds_after_finished >= 0
.This change is