Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for experiments in the CLI. #159

Merged
merged 14 commits into from
Nov 9, 2018
Merged

Adding support for experiments in the CLI. #159

merged 14 commits into from
Nov 9, 2018

Conversation

vicaire
Copy link
Contributor

@vicaire vicaire commented Nov 9, 2018

This change is Reviewable

@vicaire vicaire removed the request for review from qimingj November 9, 2018 02:17
@vicaire vicaire changed the title [WIP] Adding support for experiments in the CLI. Adding support for experiments in the CLI. Nov 9, 2018
@IronPan
Copy link
Member

IronPan commented Nov 9, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 9, 2018
@vicaire
Copy link
Contributor Author

vicaire commented Nov 9, 2018

Got /lgtm from IronPan. Checking in to unblock the PRs that depend on the pipeline client wrapper.

@vicaire vicaire merged commit 49db170 into master Nov 9, 2018
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants