SDK - Improve errors when ContainerOp.output is unavailable #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ContainerOp.output is only available when there is only one output. Right now, when there are multiple outputs it just holds `None` instead of the a task output reference. In this case however it's indistinguishable from just passing None argument. This PR gives a quick fix to make accessing the nonexistent `.output` a compile-time error.
|
Please fix the test errors. |
…ut-is-unavailable
I've fixed the errors. |
|
All the tests pass. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
IronPan
deleted the
SDK---Improve-errors-when-ContainerOp.output-is-unavailable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContainerOp.output is only available when there is only one output.
Right now, when there are multiple outputs it just holds
Noneinstead of the a task output reference.In this case however it's indistinguishable from just passing None argument.
This PR gives a quick fix to make accessing the nonexistent
.outputa compile-time error.This change is