-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Visualization API endpoint #1565
Add Visualization API endpoint #1565
Conversation
After investigating the current visualization components, I noticed that input paths are provided as a pattern rather than an array of strings as seen here and here. I believe it may be best to change the inputPaths parameter in the protobuf file to take in a single string to duplicate current behavior rather than an array of strings. |
backend/api/visualization.proto
Outdated
|
||
message Visualization { | ||
// Output. Unique visualization ID. Generated by API server. | ||
string id = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would the ID be used? If not maybe it can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For predefined visualizations it may not be necessary. However, for custom visualizations we will need a way to differentiate them if we only have a single enum type to denote custom visualizations.
These are required for the new roc curve and will become import for passing any parameters form a user to the visualization.
/hold |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is