Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer CRD controller running under namespace #1562

Merged
merged 8 commits into from
Jul 3, 2019
Merged

Viewer CRD controller running under namespace #1562

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6e989a3
Viewer CRD controller running under namespace
jingzhang36 Jun 26, 2019
f3938c9
Change docker file and add manifest deployment yaml to support the ne…
jingzhang36 Jul 1, 2019
c326414
Change docker file to support new flag namespace for viewer crd contr…
jingzhang36 Jul 1, 2019
1832310
Modify kustomization.yaml and namespaced-install.yaml
jingzhang36 Jul 1, 2019
357add0
Change file name from ml-pipeline-viewer-crd-deployment to ml-pipelin…
jingzhang36 Jul 1, 2019
ed225dc
Fix typo
jingzhang36 Jul 1, 2019
59bbec4
Remove some duplicate configs in namespaced-install
jingzhang36 Jul 1, 2019
4074b75
Merge branch 'master' into test1
jingzhang36 Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change docker file to support new flag namespace for viewer crd contr… 
…oller
  • Loading branch information
@jingzhang36
jingzhang36 committed Jul 1, 2019
commit c3264145d71129d19b8e75ce7d5bbaf4e6ec2fe5
3 changes: 2 additions & 1 deletion backend/Dockerfile.viewercontroller
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ COPY --from=builder /src/github.com/kubeflow/pipelines/third_party/license.txt /
RUN chmod +x /bin/controller

ENV MAX_NUM_VIEWERS "50"
ENV NAMESPACE "kubeflow"

CMD /bin/controller -alsologtostderr=true -max_num_viewers=${MAX_NUM_VIEWERS}
CMD /bin/controller -alsologtostderr=true -max_num_viewers=${MAX_NUM_VIEWERS} --namespace=${NAMESPACE}