Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Fix unit test #1553

Closed
wants to merge 1 commit into from
Closed

SDK - Fix unit test #1553

wants to merge 1 commit into from

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 25, 2019

json.dumps probably produces different formatting on Python 3.5 vs 3.6+


This change is Reviewable

json.dumps probably produces different formatting on Python 3.5 vs 3.6+
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ark-kun
You can assign the PR to them by writing /assign @ark-kun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@elikatsis elikatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is a proper way to test it.

@derekhh has submitted a PR (#1554) which seems pretty good. WDYT?

Copy link
Member

@abhi-g abhi-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elikatsis
Copy link
Member

Closing in favor of #1558
/close

@k8s-ci-robot
Copy link
Contributor

@elikatsis: Closed this PR.

In response to this:

Closing in favor of #1558
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@IronPan IronPan deleted the SDK---Fix-unit-test branch July 31, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants