Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline sample: Updated research notebook to use Seaborn #1546

Merged
merged 3 commits into from
Jun 28, 2019
Merged

Pipeline sample: Updated research notebook to use Seaborn #1546

merged 3 commits into from
Jun 28, 2019

Conversation

kweinmeister
Copy link
Contributor

@kweinmeister kweinmeister commented Jun 24, 2019 •
edited by jlewi
Loading

Updated notebook to use Seaborn for visualization, and minor cleanup and commenting.

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @kweinmeister. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hongye-sun
hongye-sun reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@hongye-sun hongye-sun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/ok-to-test

@kweinmeister
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@k8s-ci-robot
Copy link
Contributor

@kweinmeister: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test kubeflow-pipeline-sample-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor

/ok-to-test

@kweinmeister
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@kweinmeister
Copy link
Contributor Author

/retest

@gaoning777
Copy link
Contributor

/test kubeflow-pipeline-sample-test

@gaoning777
Copy link
Contributor

/lgtm

@kweinmeister
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0e639fd into kubeflow:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongye-sun hongye-sun hongye-sun left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@gaoning777 gaoning777

@hongye-sun hongye-sun

Labels
approved lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kweinmeister @k8s-ci-robot @gaoning777 @hongye-sun