Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize namespace and suppress pod error #1539

Merged
merged 1 commit into from
Jun 22, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Jun 21, 2019

  1. Parameterize namespace from env
  2. Log pod error instead of throwing the exception

This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Jun 22, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9be6aad into kubeflow:master Jun 22, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…ubeflow#1539)

* Added mutext

* add package

* pass as ref instead of copy

* updated after feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants