Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 7 auto-generated change log for release 0.1.21 #1527

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Step 7 auto-generated change log for release 0.1.21 #1527

merged 2 commits into from
Jun 27, 2019

Conversation

jingzhang36
Copy link
Contributor

@jingzhang36 jingzhang36 commented Jun 18, 2019 •
edited by jlewi
Loading

This change is Reviewable

@jingzhang36 jingzhang36 mentioned this pull request Jun 18, 2019
Closed
@jingzhang36
Copy link
Contributor Author

/assign @IronPan
/assign @Ark-kun
/assign @gaoning777

@IronPan
Copy link
Member

IronPan commented Jun 20, 2019

could you just keep the note for this release and revert changes for the past ones.

@jingzhang36
Copy link
Contributor Author

jingzhang36 commented Jun 20, 2019 •
edited
Loading

could you just keep the note for this release and revert changes for the past ones.

You mean manually curate this PR? I thought this automatically generated changes are not meant to be curated manually. Is it because my local repo is somehow messed up so that some unrelated changes got in?

Any way, I manually removed the changes that are related to releases other than 0.1.21.

@jingzhang36
Copy link
Contributor Author

/assign @IronPan

@IronPan
Copy link
Member

IronPan commented Jun 27, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan IronPan merged commit 924d110 into master Jun 27, 2019
@IronPan IronPan deleted the change_log branch June 28, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@Ark-kun Ark-kun

@IronPan IronPan

@gaoning777 gaoning777

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jingzhang36 @IronPan @k8s-ci-robot @Ark-kun @gaoning777