SDK/Lightweight - Added python version compatibility checks #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_code_using_cloudpickle
See my compatibility analysis: cloudpipe/cloudpickle#293
Ark-kun
force-pushed
the
SDK---Added-python-version-compatibility-checks
branch
from
9b02539
to
eb6b9b5
Compare
hongye-sun
reviewed
Jun 20, 2019
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gaoning777
reviewed
Jun 24, 2019
| if ( | ||
| current_python_version[0] != pickler_python_version[0] or | ||
| current_python_version[1] < pickler_python_version[1] or | ||
| current_python_version[0] == 3 and ((pickler_python_version[1] < 6) != (current_python_version[1] < 6)) |
There was a problem hiding this comment.
suggesting to use '()' to group the conditions combined by 'and'.
Because the 'or' operator has higher precedence than 'and', the codes are fine.
The suggestion is simply for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is