sample tests using the dataset in the corresponding test project #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
1 similar comment
|
/retest |
|
/test presubmit-e2e-test |
1 similar comment
|
/test presubmit-e2e-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
approved these changes
Nov 9, 2018
|
/lgtm |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* Ignore KeyError exception in argo_client.log_status
A lot of workflows have been flaky because of this exception.
```
ERROR|2018-06-06T21:31:19|/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py|210| Exception occurred: 'status'
Traceback (most recent call last):
File "/src/kubeflow/testing/py/kubeflow/testing/run_e2e_workflow.py", line 196, in run
status_callback=argo_client.log_status)
File "/usr/local/lib/python2.7/dist-packages/retrying.py", line 49, in wrapped_f
return Retrying(*dargs, **dkw).call(f, *args, **kw)
File "/usr/local/lib/python2.7/dist-packages/retrying.py", line 212, in call
raise attempt.get()
File "/usr/local/lib/python2.7/dist-packages/retrying.py", line 247, in get
six.reraise(self.value[0], self.value[1], self.value[2])
File "/usr/local/lib/python2.7/dist-packages/retrying.py", line 200, in call
attempt = Attempt(fn(*args, **kwargs), attempt_number, False)
File "/src/kubeflow/testing/py/kubeflow/testing/argo_client.py", line 58, in wait_for_workflows
status_callback(results)
File "/src/kubeflow/testing/py/kubeflow/testing/argo_client.py", line 22, in log_status
workflow["status"]["phase"])
KeyError: 'status'
```
Fixes kubeflow/testing#147
* Update
* Update
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* initial Alibi explainer * separate out explainer method to separate class file * Add README and update dependencies * Update kfserver * review updates * place explain back on KFModel abstract class * fix camel/snake case nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is