SDK/Lightweight - Disabled code pickling by default #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ark-kun
force-pushed
the
SDK---Lightweight---Disabled-code-pickling-by-default
branch
2 times, most recently
from
ea0b2da
to
5832419
Compare
I've introduced code pickling to capture dependencies in kubeflow#1372 Later I've discovered that there is a serious opcode incompatibility between python versions 3.5 and 3.6+. See my analysis of the issue: cloudpipe/cloudpickle#293 Dues to this issue I decided to switch back to using source code copying by default and to continue improving it. Until we stop supporting python 3.5 (kubeflow#668) it's too dangerous to use code pickling by default. Code pickling can be enabled by specifying `pickle_code=True` when calling `func_to_container_op`
Ark-kun
force-pushed
the
SDK---Lightweight---Disabled-code-pickling-by-default
branch
from
5832419
to
d5f0ec6
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
Ark-kun
deleted the
SDK---Lightweight---Disabled-code-pickling-by-default
branch
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* manifests: Add base ui manifests Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * manifests: Move patches to distinct folder Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * manifests: Extend kubeflow overlay for the ui Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * manifests: Add ui to the base manifests Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: Remove 'namespace: kubeflow' from default We will let kustomize replace the namespace and not use a specific one in the objects. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: Explicitly use namespace: kfserving-system In order to ensure Kustomize substitutes the name correctly we: 1. removed the `namespace: kfserving-system` from the web-app's kustomization file 2. explicitly use `namespace: kfserving-system` in all of the yamls Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: Use ingressGateway vars instead of patch Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: Use kfserving-system service in vsvc Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: Use v1beta1 vsvc in kustomization Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: Add a kfserving- prefix Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've introduced code pickling to capture dependencies in #1372
Later I've discovered that there is a serious opcode incompatibility between python versions 3.5 and 3.6+. See my analysis of the issue: cloudpipe/cloudpickle#293
Due to this issue I decided to switch back to using source code copying by default and to continue improving it.
Until we stop supporting python 3.5 (#668) it's better to disable code pickling by default.
Code pickling can be enabled by specifying
use_code_pickling=Truewhen callingfunc_to_container_opThis change is