Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself as a approver/reviewer. #1503

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Conversation

neuromage
Copy link
Contributor

@neuromage neuromage commented Jun 13, 2019

/assign @vicaire
/assign @IronPan

Realized I'm not able to approve any PRs. Feel free to push back.


This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Jun 14, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neuromage
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 347db49 into kubeflow:master Jun 17, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 17, 2019

Realized I'm not able to approve any PRs.

Can you give an example?
I'm not in that list and I can approve PRs just fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants