Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend - Show customized task display names #1463

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 6, 2019

Fixes #1397
Fixes #1378


This change is Reviewable

@rileyjbauer
Copy link
Contributor

Very cool. Thank you for this!
/lgtm
/approve

Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Error: "The key 'metadata' is not sorted alphabetically"
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 6, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rileyjbauer
Copy link
Contributor

/lgtm

@Ark-kun Ark-kun merged commit 7d69cda into kubeflow:master Jun 7, 2019
@Ark-kun Ark-kun deleted the Frontend---Show-customized-task-display-names branch June 7, 2019 00:36
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants