-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK - Skip attributes with missing values during PipelineMeta serialization #1448
SDK - Skip attributes with missing values during PipelineMeta serialization #1448
Conversation
a608fba
to
a64ca7a
Compare
How about leaving the value as empty instead of skipping it? |
/test kubeflow-pipeline-e2e-test |
Hmm. The intent for this PR was to skip the values that are not set or empty. I think that it's better to only produce the minimal output that has only the required information. |
a64ca7a
to
0f745f1
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…zation (kubeflow#1448) * SDK - Skip attributes with missing values during PipelineMeta serialization * Fixed the tests
Before:
after:
This change is