Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose add_op_transformer in the PipelineConf and add an example #1440

Merged
merged 2 commits into from
Jun 6, 2019
Merged

expose add_op_transformer in the PipelineConf and add an example #1440

merged 2 commits into from
Jun 6, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Jun 4, 2019

This change is Reviewable

Copy link
Member

@elikatsis elikatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaoning777
Hi, just a minor phrasal fix suggestion.

sdk/python/kfp/dsl/_pipeline.py Show resolved Hide resolved
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 5, 2019

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

3 similar comments
@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 5, 2019

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 6, 2019

\lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 6, 2019

/lgtm

@gaoning777 gaoning777 merged commit 86a49e9 into kubeflow:master Jun 6, 2019
@gaoning777 gaoning777 deleted the add-sample-pipeline-transformer branch June 6, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants